Page MenuHomePhabricator
Differential D1491

Nits cleanup in CMerkleBlock definition
ClosedPublic
Actions

Authored by jasonbcox on Jun 9 2018, 00:17.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGa8f3a799642b: Nits cleanup in CMerkleBlock definition
rABCa8f3a799642b: Nits cleanup in CMerkleBlock definition
Summary

see title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2722
Build 3556: Bitcoin ABC Buildbot (legacy)
Build 3555: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 9 2018, 00:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2018, 00:17
teamcity added a subscriber: teamcity.Jun 9 2018, 00:17

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 9 2018, 00:51

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2722: Diff 4095.Jun 9 2018, 00:51
schancel accepted this revision.Jun 12 2018, 09:52
schancel added inline comments.
src/merkleblock.h
164

Can you make this an intelligible english sentence while we're at it? :)

This revision is now accepted and ready to land.Jun 12 2018, 09:52
deadalnix added inline comments.Jun 12 2018, 14:33
src/merkleblock.h
164

And a doc comment :)

jasonbcox updated this revision to Diff 4117.Jun 13 2018, 16:57

Fixed comment according to feedback

jasonbcox marked 2 inline comments as done.Jun 13 2018, 16:57
teamcity added a comment.Jun 13 2018, 16:58

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

schancel added inline comments.Jun 13 2018, 17:07
src/merkleblock.h
143 ↗(On Diff #4117)

Maybe:

/**
 * CMerkleBlock is used to relay block headers plus a list of merkle proofs for a given set of transactions.  It is typically used with SPV nodes.
 */
164 ↗(On Diff #4117)
Initialize a CMerkleBlock from a given block, and construct merkle proofs for the provided set of transaction ids.
jasonbcox updated this revision to Diff 4118.Jun 13 2018, 17:22

Added more comments because the surrounding comments are confusing

teamcity added a comment.Jun 13 2018, 17:24

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 13 2018, 17:32

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2736: Diff 4117.Jun 13 2018, 17:32
teamcity added a comment.Jun 13 2018, 17:58

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2737: Diff 4118.Jun 13 2018, 17:58
Closed by commit rABCa8f3a799642b: Nits cleanup in CMerkleBlock definition (authored by jasonbcox). · Explain WhyJun 13 2018, 20:42
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
5 lines

Diff 4095

View Options

src/merkleblock.h

Loading...