Similar to D14102, this diff moves the websocket specific urls out of Ticker.js and into its own config.
Details
Details
- Reviewers
bytesofman Fabien - Group Reviewers
Restricted Project - Commits
- rABC1a7627283b8b: [Cashtab] Move the websocket config out of Ticker.js
- grep -r config.websocketDisconnectedRefreshInterval src/ and ensure no results
- grep -r config.websocketConnectedRefreshInterval src/ and ensure no results
- npm test
- npm start and observe successful wallet refresh intervals
- send XEC tx and ensure successful broadcast
- receive XEC tx and ensure successful websocket detection
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- websocket_config
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24156 Build 47922: Build Diff cashtab-tests Build 47921: arc lint + arc unit
Event Timeline
| cashtab/src/config/websocket.js | ||
|---|---|---|
| 8 ↗ | (On Diff #40945) | Nit: move the comment above, and you can just say time is in ms :) |