Page MenuHomePhabricator
Differential D1492

Remove unecessary calls to GetSatoshis and Amount creation.
ClosedPublic
Actions

Authored by deadalnix on Jun 9 2018, 12:44.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING49a8cb7b4e0a: Remove unecessary calls to GetSatoshis and Amount creation.
rABC49a8cb7b4e0a: Remove unecessary calls to GetSatoshis and Amount creation.
Summary

As per title. No need to prematurely drop typing when not necessary.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
removeredundantgetsat
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2724
Build 3560: Bitcoin ABC Buildbot (legacy)
Build 3559: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 9 2018, 12:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2018, 12:44
teamcity added a subscriber: teamcity.Jun 9 2018, 12:44

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 4097.Jun 9 2018, 12:50

Add some obiously overlooked instance.

teamcity added a comment.Jun 9 2018, 12:52

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2723: Diff 4096.Jun 9 2018, 13:19
teamcity added a comment.Jun 9 2018, 13:19

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2724: Diff 4097.Jun 9 2018, 13:29
teamcity added a comment.Jun 9 2018, 13:29

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

schancel accepted this revision.Jun 12 2018, 12:49
This revision is now accepted and ready to land.Jun 12 2018, 12:49
Closed by commit rABC49a8cb7b4e0a: Remove unecessary calls to GetSatoshis and Amount creation. (authored by deadalnix). · Explain WhyJun 12 2018, 12:52
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
8 lines
primitives/
8 lines
rpc/
9 lines
script/
2 lines
test/
4 lines
6 lines

Diff 4097

View Options

src/amount.cpp

Loading...
View Options

src/primitives/transaction.cpp

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/script/interpreter.cpp

Loading...
View Options

src/test/amount_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...