Page MenuHomePhabricator

Merged /test/functional/README into functional-tests
ClosedPublic

Authored by jasonbcox on Jun 14 2018, 00:41.

Details

Summary

There was a goof in D1497 where I said I moved /test/functional/README but actually moved /test/README.
This diff merges /test/functional/README with what was /test/README turned functional-tests.md.
Completes T357, whereas D1497 actually completed T356.

Test Plan

read it

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1503
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2744
Build 3599: Bitcoin ABC Buildbot (legacy)
Build 3598: arc lint + arc unit

Event Timeline

schancel requested changes to this revision.Jun 15 2018, 12:11

Rest of the content looks good.

doc/functional-tests.md
10 ↗(On Diff #4122)

You added a wild period.

18 ↗(On Diff #4122)

What's the rational for kicking this down a line?

160 ↗(On Diff #4122)

Wild mid-dot appears.

163 ↗(On Diff #4122)

What is Going On with The casing Here?

167 ↗(On Diff #4122)

Please make this file use a consistent hard wrap.

199 ↗(On Diff #4122)

Wrap is weird here again.

This revision now requires changes to proceed.Jun 15 2018, 12:11
jasonbcox added inline comments.
doc/functional-tests.md
10 ↗(On Diff #4122)

Weird. This isn't even a period, but rather a bullet point. Not even sure how I managed to create it in the first place.

18 ↗(On Diff #4122)

It doesn't match the rest of the doc having one line so long. As a result, it renders poorly in vim. I've fixed the wrapping in accordance with your other feedback.

jasonbcox marked 2 inline comments as done.

Fixed according to all feedback.

This revision is now accepted and ready to land.Jun 18 2018, 12:47
This revision was automatically updated to reflect the committed changes.