Page MenuHomePhabricator
Differential D1500

Move get_srcdir to where it is used
ClosedPublic
Actions

Authored by schancel on Jun 13 2018, 10:29.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING37fb1629e725: Move get_srcdir to where it is used
rABC37fb1629e725: Move get_srcdir to where it is used
Summary

Move get_srcdir function to cdefs.py, it's only
usage location.

Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Jun 13 2018, 10:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2018, 10:29
teamcity added a subscriber: teamcity.Jun 13 2018, 10:31

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 13 2018, 11:07

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2734: Diff 4112.Jun 13 2018, 11:07
jasonbcox requested changes to this revision.Jun 13 2018, 21:11
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/test_framework/cdefs.py
23 ↗(On Diff #4112)

Remove this line ;)

This revision now requires changes to proceed.Jun 13 2018, 21:11
schancel added inline comments.Jun 15 2018, 11:19
test/functional/test_framework/cdefs.py
23 ↗(On Diff #4112)

Please approve and note for requests like this.

schancel updated this revision to Diff 4126.Jun 15 2018, 11:23

Remove TODO comment

teamcity added a comment.Jun 15 2018, 11:25

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 15 2018, 11:58

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2743: Diff 4126.Jun 15 2018, 11:58
jasonbcox accepted this revision.Jun 15 2018, 17:07
This revision is now accepted and ready to land.Jun 15 2018, 17:07
Closed by commit rABC37fb1629e725: Move get_srcdir to where it is used (authored by schancel). · Explain WhyJun 18 2018, 13:20
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
44 lines
45 lines

Diff 4131

View Options

test/functional/test_framework/cdefs.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...