Differential D1494

Various nits in wallet.cpp
ClosedPublic
Actions

Authored by deadalnix on Jun 9 2018, 14:56.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING3b66a5e69ea4: Various nits in wallet.cpp
rABC3b66a5e69ea4: Various nits in wallet.cpp

Summary

Mostly C++11 style loops, braces and outpt => outpoint

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

walletnits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2748
Build 3607: Bitcoin ABC Buildbot (legacy)
Build 3606: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 9 2018, 14:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2018, 14:56

Ooops, this is actually broken.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B2726: Diff 4099!Jun 9 2018, 15:29

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

schancel accepted this revision.Jun 12 2018, 15:11

Fixed it.

This revision is now accepted and ready to land.Jun 18 2018, 13:30

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2748: Diff 4133.Jun 18 2018, 14:10

Closed by commit rABC3b66a5e69ea4: Various nits in wallet.cpp (authored by deadalnix). · Explain WhyJun 18 2018, 23:24

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D4166: Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety.Sep 27 2019, 17:40

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

90 lines

Diff 4133

View Options

Various nits in wallet.cppClosedPublicActions