Page MenuHomePhabricator
Differential D14244

[ecash-herald] Update var name to better reflect purpose
ClosedPublic
Actions

Authored by bytesofman on Jul 10 2023, 20:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5953a06fb0e9: [ecash-herald] Update var name to better reflect purpose
Summary

Depends on D14226

This amount used to be XEC. After app was upgraded to support fiat amounts, this amount is either fiat or XEC (if coingecko price API fails).

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
show-amounts-for-cashtab-msgs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24450
Build 48500: Build Diffecash-herald-tests
Build 48499: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 10 2023, 20:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2023, 20:55
bytesofman requested review of this revision.Jul 10 2023, 20:55
Harbormaster completed remote builds in B24438: Diff 41364.Jul 10 2023, 20:56
Fabien requested changes to this revision.Jul 11 2023, 07:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/src/parse.js
1425 ↗(On Diff #41364)

So same as the other diff, the comment is wrong (or at least misleading)

This revision now requires changes to proceed.Jul 11 2023, 07:17
bytesofman updated this revision to Diff 41383.Jul 11 2023, 17:12

Remove legacy comment

Harbormaster completed remote builds in B24450: Diff 41383.Jul 11 2023, 17:14
Fabien accepted this revision.Jul 11 2023, 18:07
This revision is now accepted and ready to land.Jul 11 2023, 18:07
Closed by commit rABC5953a06fb0e9: [ecash-herald] Update var name to better reflect purpose (authored by bytesofman). · Explain WhyJul 11 2023, 18:33
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC5953a06fb0e9: [ecash-herald] Update var name to better reflect purpose.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
src/
7 lines

Diff 41383

View Options

apps/ecash-herald/src/parse.js

Loading...