[chronik-client] Bump version number
ClosedPublic
Actions

Authored by bytesofman on Jul 16 2023, 18:07.

Details

Reviewers

emack
Mengerian

Group Reviewers

Restricted Project

Commits

rABC55b8b92685da: [chronik-client] Bump version number

Summary

Republished chronik-client after building. Subsequent diff will automate this process.

Test Plan

Confirm minor version change

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-client-republish

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24505
Build 48610: Build Diff
Build 48609: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 16 2023, 18:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2023, 18:07

bytesofman requested review of this revision.Jul 16 2023, 18:07

Harbormaster completed remote builds in B24505: Diff 41457.Jul 16 2023, 18:07

emack accepted this revision.Jul 16 2023, 22:27

This revision is now accepted and ready to land.Jul 16 2023, 22:27

I'm not sure exactly what's going on here, but seems like a flaw in the process if it relies on not forgetting to do something. Is this something that could be automated?

Also, The commit message seems weird, it's including extra info than just describing what the commit is actually changing. I'd expect the commit message to be something like "Bump chronik-client version number", and then if you need additional context include that below.

In D14270#319251, @Mengerian wrote:

I'm not sure exactly what's going on here, but seems like a flaw in the process if it relies on not forgetting to do something. Is this something that could be automated?

Also, The commit message seems weird, it's including extra info than just describing what the commit is actually changing. I'd expect the commit message to be something like "Bump chronik-client version number", and then if you need additional context include that below.

Updated diff title and comment. Subsequent diff will patch and add automation, D14271

Mengerian accepted this revision.Jul 17 2023, 14:36

Closed by commit rABC55b8b92685da: [chronik-client] Bump version number (authored by bytesofman). · Explain WhyJul 17 2023, 22:49

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC55b8b92685da: [chronik-client] Bump version number.

emack mentioned this in D14271: [chronik-client] Add prepublish command to prevent unbuilt npm deployments.Jul 18 2023, 14:01