Page MenuHomePhabricator
Differential D14284

[electrum] AppImage: Remove glib libraries from bundle to make QR scanner work
ClosedPublic
Actions

Authored by PiRK on Jul 19 2023, 07:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC655e0b61a68d: [electrum] AppImage: Remove glib libraries from bundle to make QR scanner work
Summary

We need to exclude the glib libraries, otherwise we can end up using
multiple incompatible versions.

We could have also included all glib libraries, but then we would have
to include the full gstreamer libraries too.

See https://github.com/AppImageCommunity/pkg2appimage/pull/500#issuecomment-1057287738

This is a backport of electroncash#2653

Test Plan

Build the AppImage, test the webcam QR code scanner on a system where it previously didn't work (Ubuntu 22.04 with an AppImage built on Debian 10)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
glib_qr_scanner
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24545
Build 48687: Build Diffelectrum-tests
Build 48686: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 19 2023, 07:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 19 2023, 07:47
Harbormaster completed remote builds in B24545: Diff 41512.Jul 19 2023, 07:49
PiRK added a comment.Jul 19 2023, 07:55

Some context for this one, from the Electron Cash telegram group:

Screenshot from 2023-07-19 09-50-58.png (366×489 px, 88 KB)

Screenshot from 2023-07-19 09-52-08.png (459×529 px, 224 KB)

Screenshot from 2023-07-19 09-52-42.png (282×499 px, 65 KB)

Screenshot from 2023-07-19 09-53-13.png (157×487 px, 30 KB)

PiRK mentioned this in D14285: [electrum] add a "Backporting" section to CONTRIBUTING.md.Jul 19 2023, 07:57
PiRK mentioned this in rABC0d21dccdf6e3: [electrum] add a "Backporting" section to CONTRIBUTING.md.Jul 19 2023, 13:53
PiRK edited the test plan for this revision. (Show Details)Jul 21 2023, 13:40
PiRK edited the test plan for this revision. (Show Details)
PiRK published this revision for review.Jul 21 2023, 14:13
PiRK edited the summary of this revision. (Show Details)
Fabien accepted this revision.Jul 21 2023, 16:51
This revision is now accepted and ready to land.Jul 21 2023, 16:51
Closed by commit rABC655e0b61a68d: [electrum] AppImage: Remove glib libraries from bundle to make QR scanner work (authored by EchterAgo, committed by PiRK). · Explain WhyJul 21 2023, 21:06
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC655e0b61a68d: [electrum] AppImage: Remove glib libraries from bundle to make QR scanner work.

Revision Contents
Changeset List

PathSize
electrum/
contrib/
build-linux/
appimage/
6 lines

Diff 41512

View Options

electrum/contrib/build-linux/appimage/_build.sh

Loading...