[chronik] Bump the RocksDb crate version to 0.21.0
ClosedPublic
Actions

Authored by Fabien on Jul 31 2023, 12:22.

Details

Reviewers

bytesofman
tobias_ruck

Group Reviewers

Restricted Project

Commits

rABC986fea30b59a: [chronik] Bump the RocksDb crate version to 0.21.0

Summary

This fixes the build with recent Clang versions that used to fail for a missing stdint header inclusion.

Test Plan

mkdir buildChronik && cd buildChronik
cmake -GNinja .. -DBUILD_BITCOIN_CHRONIK=ON
ninja all check-crates
./test/functional/test_runner.py chronik_*

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rocksdb_0.21.0

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24629
Build 48855: Build Diff	build-chronik
Build 48854: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 31 2023, 12:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2023, 12:22

Fabien requested review of this revision.Jul 31 2023, 12:22

Harbormaster completed remote builds in B24629: Diff 41642.Jul 31 2023, 12:42

for test plans involving ninja ...

Is it implied that I should also be building everything in a build folder, then running from there?

If I run ninja check-crates from build/ , I get ninja: error: unknown target 'check-crates'

In D14327#320897, @bytesofman wrote:

for test plans involving ninja ...

Is it implied that I should also be building everything in a build folder, then running from there?

If I run ninja check-crates from build/ , I get ninja: error: unknown target 'check-crates'

Yes. I can update the test plan with full instructions for this time

Fabien edited the test plan for this revision. (Show Details)Aug 1 2023, 05:22

bytesofman accepted this revision.Aug 1 2023, 20:46

This revision is now accepted and ready to land.Aug 1 2023, 20:46

tobias_ruck accepted this revision.Aug 1 2023, 21:01

Closed by commit rABC986fea30b59a: [chronik] Bump the RocksDb crate version to 0.21.0 (authored by Fabien). · Explain WhyAug 2 2023, 13:45

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC986fea30b59a: [chronik] Bump the RocksDb crate version to 0.21.0.