Remove the -bip9params flag
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2018, 12:32.

Details

Reviewers

schancel
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING3f5eb8ef92cb: Remove the -bip9params flag
rABC3f5eb8ef92cb: Remove the -bip9params flag

Summary

It is untested and not used.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

killUpdateBIP9Parameters

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2798
Build 3706: Bitcoin ABC Buildbot (legacy)
Build 3705: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 4 2018, 12:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2018, 12:32

Harbormaster failed remote builds in B2798: Diff 4200!Jul 4 2018, 12:32

Add a note in the release notes

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2800: Diff 4202.Jul 4 2018, 16:00

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

schancel accepted this revision.Jul 5 2018, 14:52

This revision is now accepted and ready to land.Jul 5 2018, 14:52

jasonbcox accepted this revision.Jul 5 2018, 15:32

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

doc/release-notes.md
6 ↗	(On Diff #4202)	... configuration and parameter.

Closed by commit rABC3f5eb8ef92cb: Remove the -bip9params flag (authored by deadalnix). · Explain WhyJul 5 2018, 20:45

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

chainparams.h

8 lines

chainparams.cpp

11 lines

init.cpp

47 lines

Diff 4200

View Options

src/chainparams.h

View Options

src/chainparams.cpp

View Options

Remove the -bip9params flagClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4200

src/chainparams.h

src/chainparams.cpp

src/init.cpp

Remove the -bip9params flag
ClosedPublic
Actions

Revision Contents
Changeset List