This is useful for the rest of the codebase too.
Next I will move COutPoint to transaction.py, and it needs this module.
Depends on D14424
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCa19be0d186fe: [electrum] move serialize.py out of avalanche
python test_runner.py
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24911 Build 49410: Build Diff electrum-tests Build 49409: arc lint + arc unit
Event Timeline
Comment Actions
diff looks good. I assume it's some kind of python linter thing that is creating so many "this changed" indications in phab due to order switching. either way, just a nit / question, does not impact the code here.
FYI I am not able to arc patch this diff without getting a git error. May need to be rebased -- as well as all subsequent diffs in this stack.
| electrum/electrumabc/avalanche/delegation.py | ||
|---|---|---|
| 34–42 ↗ | (On Diff #42002) | did the order need to change here? Is that a python thing, import all the .. before the . ? I can see that this pattern is maintained but the net effect makes it look like a lot of things changed ... though the extra . preceding serialize seems to be the only actual change. |