Page MenuHomePhabricator
Differential D1534

Added block index test for disk positions
ClosedPublic
Actions

Authored by jasonbcox on Jul 3 2018, 17:02.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING4185a8979743: Added block index test for disk positions
rABC4185a8979743: Added block index test for disk positions
Summary

Continues work on T355. Depends on D1533.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
index2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2809
Build 3722: Bitcoin ABC Buildbot (legacy)
Build 3721: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 3 2018, 17:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2018, 17:02
jasonbcox edited the summary of this revision. (Show Details)Jul 3 2018, 17:03
jasonbcox added a parent revision: D1533: Added test file for CBlockIndex, including a test for get block header..
teamcity added a subscriber: teamcity.Jul 3 2018, 17:04

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 3 2018, 17:39

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2794: Diff 4195.Jul 3 2018, 17:39
jasonbcox added a child revision: D1535: Added a block index test for received time.Jul 3 2018, 18:17
deadalnix requested changes to this revision.Jul 4 2018, 22:26
deadalnix added inline comments.
src/test/blockindex_tests.cpp
40 ↗(On Diff #4195)

Creating a std::set or std::array or all the validities possible and loop over it C++11 style would be better IMO.

See blockstatus_tests.cpp for reference.

This revision now requires changes to proceed.Jul 4 2018, 22:26
jasonbcox updated this revision to Diff 4215.Jul 5 2018, 18:45

Use set of validity values instead of casting ints

teamcity added a comment.Jul 5 2018, 18:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 5 2018, 19:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2809: Diff 4215.Jul 5 2018, 19:24
deadalnix accepted this revision.Jul 6 2018, 11:49
This revision is now accepted and ready to land.Jul 6 2018, 11:49
Closed by commit rABC4185a8979743: Added block index test for disk positions (authored by jasonbcox). · Explain WhyJul 9 2018, 14:24
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
49 lines

Diff 4215

View Options

src/test/blockindex_tests.cpp

Loading...