Page MenuHomePhabricator

[electrum] rename tx_from_str to rawtx_from_str
ClosedPublic

Authored by PiRK on Sep 25 2023, 06:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8026628e786b: [electrum] rename tx_from_str to rawtx_from_str
Summary

Make it clear that the function does not return a Transaction object.

Improve documentation and clean up the code. No need to catch Exception, only ValueError makes sense if the string is not hex.
Depends on D14524

Test Plan
./electrum-abc deserialize 02000000012367ad0da9fb8f8a7e574d55d4eb2dd0fd8ebd58b1c21cfddb9fe5426369082a000000006441761c8b702e06fcb8656cb205454f22efff174e3ae9552c1ee83f7d64e3b0d29fa466c48a82597713fd7a3c03e324855349a76660fa26dfec4922c51ea0f51cb6412102a42cd220e6099d5d678066b81813ae4fdd14b290479962ae5c0af1448113bcb4feffff

./electrum-abc deserialize spam

In the application, menu Tools > Load Transaction > From Text

To test the JSON format, go to the Send tab, prepare a transaction, click Preview then Save. Then menu Tools > Load Transaction > From File

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tx_rax_bytes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25149
Build 49886: Build Diffelectrum-tests
Build 49885: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Sep 25 2023, 06:42
PiRK edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Sep 25 2023, 09:02