Page MenuHomePhabricator
Differential D1555

Added test for CBlockIndexWorkComparator
ClosedPublic
Actions

Authored by jasonbcox on Jul 10 2018, 18:41.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING962c7f726581: Added test for CBlockIndexWorkComparator
rABC962c7f726581: Added test for CBlockIndexWorkComparator
Summary

CBlockIndexWorkComparator is lacking tests. Required to fulfill testing requirements for D1442.

Depends on D1536.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
comp4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2841
Build 3786: Bitcoin ABC Buildbot (legacy)
Build 3785: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 10 2018, 18:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2018, 18:41
teamcity added a subscriber: teamcity.Jul 10 2018, 18:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Jul 10 2018, 18:42
jasonbcox added a parent revision: D1536: Move CBlockIndexWorkComparator to its own header.
jasonbcox mentioned this in D1442: Discourage selfish mining by favoring blocks with more accurate timestamps.
jasonbcox planned changes to this revision.Jul 10 2018, 20:44
Harbormaster failed remote builds in B2839: Diff 4260!Jul 10 2018, 20:47
jasonbcox updated this revision to Diff 4262.Jul 10 2018, 21:11

Fixed silly bug

teamcity added a comment.Jul 10 2018, 21:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox updated this revision to Diff 4263.Jul 10 2018, 21:34

Fix test so that it doesn't try to check equal nSequenceId when it's checking for inequality

teamcity added a comment.Jul 10 2018, 21:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B2841: Diff 4262!Jul 10 2018, 21:45
teamcity added a comment.Jul 10 2018, 21:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox added a child revision: D1442: Discourage selfish mining by favoring blocks with more accurate timestamps.Jul 10 2018, 21:46
teamcity added a comment.Jul 10 2018, 22:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2842: Diff 4263.Jul 10 2018, 22:17
deadalnix requested changes to this revision.Jul 12 2018, 11:48

There is no test for the block time accuracy.

src/test/work_comparator_tests.cpp
48 ↗(On Diff #4263)

This is undefined behavior.

This revision now requires changes to proceed.Jul 12 2018, 11:48
jasonbcox added a comment.Jul 12 2018, 15:27
In D1555#32140, @deadalnix wrote:

There is no test for the block time accuracy.

That will come as part of D1442.

jasonbcox updated this revision to Diff 4289.Jul 12 2018, 15:34

Removed check on undefined behavior

teamcity added a comment.Jul 12 2018, 15:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox planned changes to this revision.Jul 12 2018, 15:37
teamcity added a comment.Jul 12 2018, 16:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2857: Diff 4289!Jul 12 2018, 16:16
teamcity added a comment.Jul 12 2018, 18:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel accepted this revision.Jul 12 2018, 18:26
teamcity added a comment.Jul 12 2018, 19:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox updated this revision to Diff 4297.Jul 13 2018, 18:03

Re-added the pointer case, but properly implemented.

teamcity added a comment.Jul 13 2018, 18:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2865: Diff 4297.Jul 13 2018, 18:40
teamcity added a comment.Jul 13 2018, 18:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jul 14 2018, 12:30
This revision is now accepted and ready to land.Jul 14 2018, 12:30
Closed by commit rABC962c7f726581: Added test for CBlockIndexWorkComparator (authored by jasonbcox). · Explain WhyJul 14 2018, 23:52
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4262

View Options

src/Makefile.test.include

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/work_comparator_tests.cpp

Loading...