Page MenuHomePhabricator

rpc: various fixups for dumptxoutset
ClosedPublic

Authored by PiRK on Oct 24 2023, 07:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4ce0b8d8253c: rpc: various fixups for dumptxoutset
Summary
  • Actually generate an assumeutxo hash and display it
  • Add nchaintx to output (necessary for use in chainparams entry)

The source PR actually duplicated the "path" field in the output. Don't do that.

This is a backport of core#23155

Depends on D14657

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Oct 24 2023, 07:08
Fabien requested changes to this revision.Oct 25 2023, 08:40
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
3160 ↗(On Diff #42737)

Macro lolfail:

test/functional/rpc_dumptxoutset.py
53 ↗(On Diff #42737)

Can we check the paths as well ? It would have prevented the previous bug

This revision now requires changes to proceed.Oct 25 2023, 08:40
test/functional/rpc_dumptxoutset.py
53 ↗(On Diff #42737)

done on line 34

PiRK edited the summary of this revision. (Show Details)

dedup "path"

It seems a bit silly to add two new params to a function just for a log line, but I think it is best to stay close to the source material on this, to reduce head-scratching and git blaming on future backports..

This revision is now accepted and ready to land.Oct 26 2023, 08:59
This revision was automatically updated to reflect the committed changes.