This two tests need root privileges to set-up a local loop network.
They are normally skipped on CI, and are currently breaking the script that
updates the timing.json file. Adding them to EXTRA_PRIVILEGES_TESTS will
let this script skip them and complete successfully.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC480c16cf2ec7: tests: add feature_bind_port_*.py to EXTRA_PRIVILEGES_TESTS
cd test/functional/
NON_TESTS=$(python3 -c 'from test_runner import NON_SCRIPTS; print(" ".join(NON_SCRIPTS))')
export NON_TESTS
EXTRA_PRIVILEGES_TESTS=$(python3 -c 'from test_runner import EXTRA_PRIVILEGES_TESTS; print(" ".join(EXTRA_PRIVILEGES_TESTS))')
export EXTRA_PRIVILEGES_TESTS
check_missing() {
# Exclude non-tests from the check
if [[ "${NON_TESTS}" =~ $1 ]] || [[ "${EXTRA_PRIVILEGES_TESTS}" =~ $1 ]]; then
exit 0
fi
if ! grep -q $1 timing.json ; then
echo "Error: Test file '$1' is missing from timing.json"
exit 1
fi
}
export -f check_missing
find . -maxdepth 1 -name '*.py' | cut -c 3- | xargs -I'{}' -n1 bash -c 'check_missing {}'Check that these two functional tests are not listed as missing from timing.json
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- fix_update_timings
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25492 Build 50565: Build Diff build-without-wallet · build-debug · build-clang-tidy · build-diff · build-clang Build 50564: arc lint + arc unit