Page MenuHomePhabricator
Differential D14852

[chronik-client] Default true for websocket keepAlive
ClosedPublic
Actions

Authored by bytesofman on Nov 24 2023, 21:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0935ae6f5067: [chronik-client] Default true for websocket keepAlive
Summary

Plan on using this on all apps that I use chronik websockets with. It would be weirder to not want to use it.

So, the default should be true.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
keepalive-default-true
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25739
Build 51058: Build Diffchronik-client-tests
Build 51057: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 24 2023, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2023, 21:41
bytesofman requested review of this revision.Nov 24 2023, 21:41
bytesofman updated this revision to Diff 43268.

Modify unit tests so that keepAlive = false is tested

Harbormaster completed remote builds in B25739: Diff 43267.Nov 24 2023, 21:43
Harbormaster completed remote builds in B25740: Diff 43268.
Fabien accepted this revision.Nov 24 2023, 21:50
This revision is now accepted and ready to land.Nov 24 2023, 21:50
Closed by commit rABC0935ae6f5067: [chronik-client] Default true for websocket keepAlive (authored by bytesofman). · Explain WhyNov 24 2023, 22:47
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC0935ae6f5067: [chronik-client] Default true for websocket keepAlive.

Revision Contents
Changeset List

PathSize
modules/
chronik-client/
src/
6 lines

Diff 43267

View Options

modules/chronik-client/src/ChronikClient.ts

Loading...