Page MenuHomePhabricator

[Cashtab][Alias] Deprecate Check Alias button
ClosedPublic

Authored by emack on Dec 2 2023, 00:33.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Commits
rABC135b0f84940a: [Cashtab][Alias] Deprecate Check Alias button
Summary

As a downstream effect of implementing UAT feedback in T3363 to parse alias status once the user stops typing for 1000ms in the input field, there is no longer a need for the Check Alias button.

This diff deprecates this button, it's function and associated UI components.

image.png (358×616 px, 39 KB)

All the UI snapshots are 'touched' in this diff because of removing the check button from the Primary Button component, which is imported across these components.

Test Plan

npm test
grep -r SmartButtonLookupOnly src/ and ensure no results
grep -r lookupAliasDetails src/ and ensure no results
grep -r AliasSearchIcon src/ and ensure no results
grep -r SearchOutlined src/ and ensure no results
grep -r SmartButtonLookupOnly src/ and ensure no results
Navigate to Alias.js and ensure the Check Alias button is no longer in the UI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecateCheckAlias
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25805
Build 51190: Build Diffcashtab-tests
Build 51189: arc lint + arc unit

Event Timeline

emack requested review of this revision.Dec 2 2023, 00:33
Fabien added a subscriber: Fabien.

less is more

This revision is now accepted and ready to land.Dec 3 2023, 11:22
This revision was automatically updated to reflect the committed changes.