Provide a template for the eCash Node Daemon Setup Guide
Details
Details
- Reviewers
Fabien Mengerian - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABC0eb2a28b9ecf: [Node Daemon ] Updating the outdated bitcoind.service.
The tests have been conducted on three different VPSs, each running Ubuntu, and each provided by a different service provider.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25808 Build 51196: Build Diff Build 51195: arc lint + arc unit
Event Timeline
Comment Actions
You should add a test plan.
As far as I know, you used this file to set up the systemd service on a server, so you can write that in the test plan.
Comment Actions
Also, I notice that we already have bitcoind.service in this directory. Wouldn't it make more sense to replace or modify that file, rather than ending up with two different but similar versions in here?
This comment was removed by alitayin.
Comment Actions
Following Antony's suggestion, abandon the creation of a new ecashd.service file and instead replace the outdated bitcoind.service.
| contrib/init/bitcoind.service | ||
|---|---|---|
| 10–11 | You should not disable the rate limiting completely. If the node refuses to start there is likely a reason and keep retrying infinitely will not help | |
Comment Actions
There's something wrong with this Diff, it's not showing the actual change against master.
You probably need to squash some commits
| contrib/init/bitcoind.service | ||
|---|---|---|
| 7 ↗ | (On Diff #43393) | You should stick to Type=forking here and add the -daemonwait option to bitcoind. |
| doc/init.md | ||
| 79 ↗ | (On Diff #43393) | The systemd service file expects the bitcoind executable to be located in ~/bitcoin-abc/bin/bitcoind, so make sure to create the directory and move or copy the file before running the following instructions. |
| 80 ↗ | (On Diff #43393) | The ~ is a shortcut for the current user home directory |
| 81 ↗ | (On Diff #43393) | |
| 82 ↗ | (On Diff #43393) | |
Comment Actions
I couldn't find any issues between 'in' and '~'. By the way, I tested -deamonwait on three nodes, and it worked perfectly.
Comment Actions
Minor nit, but looks like you're making very wide lines in init.md
I'm not sure what the standard is, but usually something like 80 or 100 characters per line is good. I also wonder why the linter doesn't catch this.
Comment Actions
I'm not sure what the standard is, but usually something like 80 or 100 characters per line is good. I also wonder why the linter doesn't catch this.
This not enforced on markdown files.
One extra duplicated line to remove and it's good to go.
| doc/init.md | ||
|---|---|---|
| 82–84 ↗ | (On Diff #43446) | |
Comment Actions
Tried this out, seems to work.
| doc/init.md | ||
|---|---|---|
| 86 ↗ | (On Diff #43500) | I'm not sure what "to enable user login" means in this context. |
Comment Actions
Clarify documentation for systemctl --user enable bitcoind
| doc/init.md | ||
|---|---|---|
| 86 ↗ | (On Diff #43500) | |
| doc/init.md | ||
|---|---|---|
| 83 ↗ | (On Diff #43530) | Random blank line here mid-sentence. |
This comment was removed by Fabien.