Move headers-direct-fetch logic into own function
ClosedPublic
Actions

Authored by PiRK on Dec 5 2023, 11:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa0058fe8593b: Move headers-direct-fetch logic into own function

Summary

And move headers direct fetch to end of ProcessHeadersMessage

Review tip:
git show --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

This should show only linter changes due to reduced indentation in the moved code block.

This is a partial backport of core#25454
https://github.com/bitcoin/bitcoin/pull/25454/commits/29c45185223441943ab610e62937a118c7c3a5b2
https://github.com/bitcoin/bitcoin/pull/25454/commits/2b341db731793844f12944363186edea23eabdeb
Depends on D14908

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25826
Build 51232: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 51231: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 5 2023, 11:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2023, 11:33

PiRK requested review of this revision.Dec 5 2023, 11:33

teamcity edited the summary of this revision. (Show Details)Dec 5 2023, 11:33

PiRK added a child revision: D14910: Move peer state updates from headers message into separate function.Dec 5 2023, 11:35

Harbormaster completed remote builds in B25826: Diff 43400.Dec 5 2023, 11:54

Fabien accepted this revision.Dec 5 2023, 16:48

This revision is now accepted and ready to land.Dec 5 2023, 16:48

Closed by commit rABCa0058fe8593b: Move headers-direct-fetch logic into own function (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by PiRK). · Explain WhyDec 5 2023, 18:25

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa0058fe8593b: Move headers-direct-fetch logic into own function.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

144 lines

Diff 43400

View Options

Move headers-direct-fetch logic into own functionClosedPublicActions