Page MenuHomePhabricator

[ecash-coinselect] Patch bug where returned outputs could be non-integer
ClosedPublic

Authored by bytesofman on Dec 5 2023, 23:04.

Details

Summary

Library must return outputs in satoshis, which must be integer values. Non-integer fee rates can create decimals.

Round up when calculating the fee as you must pay sufficient fee, and the output should be correspondingly lower as the fee is implied.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-coinselect-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25835
Build 51250: Build Diffecash-coinselect
Build 51249: arc lint + arc unit