Page MenuHomePhabricator

[Cashtab] Implement better tx functions on Send screen
ClosedPublic

Authored by bytesofman on Dec 6 2023, 23:45.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCbbf7fccdfb67: [Cashtab] Implement better tx functions on Send screen
Summary

Implement new transaction functions for Cashtab send screen

Test Plan

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-use-new-tx-fn
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25994
Build 51562: Build Diffcashtab-tests
Build 51561: arc lint + arc unit

Event Timeline

reference point, some of this needs to be done in other diffs

Implement updated ecash-coinselect, test on airdrop txs

need unit test for helper function getMultisendTargetOutputs

Add OP_RETURN at index 0 due to personal preference

cashtab/package.json
39

Update is necessary to start using this tx functin in prod as the bug patched in 2.0.3 is basically guaranteed to hit with Cashtab's existing appConfig.defaultFee of 2.01 satoshis per byte

D14916

cashtab/src/transactions/fixtures/vectors.js
216

This error msg comes from ecash-coinselect, updated in 2.0.2

This revision is now accepted and ready to land.Dec 20 2023, 10:09