Page MenuHomePhabricator
Differential D1585

Updated CONTRIBUTING.md with install instructions for autopep8
ClosedPublic
Actions

Authored by jasonbcox on Jul 22 2018, 20:41.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGc005108d6d68: Updated CONTRIBUTING.md with install instructions for autopep8
rABCc005108d6d68: Updated CONTRIBUTING.md with install instructions for autopep8
Summary

autopep8 is not intuitive to install for devs not familiar with it and/or pip.

Test Plan

Installed using this method.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
contrib-docs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2916
Build 3936: Bitcoin ABC Buildbot (legacy)
Build 3935: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 22 2018, 20:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2018, 20:41
teamcity added a subscriber: teamcity.Jul 22 2018, 20:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2916: Diff 4367.Jul 22 2018, 21:22
teamcity added a comment.Jul 22 2018, 21:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Jul 23 2018, 21:42
deadalnix added inline comments.
CONTRIBUTING.md
133

Or simply

sudo apt install python-autopep8
This revision now requires changes to proceed.Jul 23 2018, 21:42
jasonbcox updated this revision to Diff 4383.Jul 24 2018, 15:18

Simplied according to feedback

teamcity added a comment.Jul 24 2018, 15:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2924: Diff 4383.Jul 24 2018, 16:00
teamcity added a comment.Jul 24 2018, 16:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jul 25 2018, 14:42
This revision is now accepted and ready to land.Jul 25 2018, 14:42
Closed by commit rABCc005108d6d68: Updated CONTRIBUTING.md with install instructions for autopep8 (authored by jasonbcox). · Explain WhyJul 25 2018, 18:24
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
7 lines

Diff 4367

View Options

CONTRIBUTING.md

Loading...