Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC79026e75747f: [Chronik] Add `TokenWriter` and `TokenReader`

Summary

Parses, colors, verifies and indexes ALP/SLP tokens in a batch (i.e. block).

This doesn't change the behavior of Chronik yet, which will come in a future diff.

Details about the indexing strategy and tradeoffs can be found in the doc comment of TokenWriter.

Depends on D15046 and D15047.

Test Plan

cargo test -p chronik-db

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-slp-token-writer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26074
Build 51721: Build Diff	chronik-client-integration-tests · build-chronik
Build 51720: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Dec 28 2023, 20:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 28 2023, 20:04

tobias_ruck requested review of this revision.Dec 28 2023, 20:04

Harbormaster completed remote builds in B26074: Diff 43790.Dec 28 2023, 20:38

add forgot comments

Harbormaster completed remote builds in B26075: Diff 43791.Dec 28 2023, 21:44

I forgot to handle unknown tokens (they are simply ignored which is not good)

redesign the DB to include unknown tokens
split tests into multiple files

Harbormaster completed remote builds in B26082: Diff 43800.Dec 30 2023, 17:53

You're missing tests for explicit BURN on both SLP and ALP

chronik/chronik-db/src/io/token/batch.rs
102 ↗	(On Diff #43800)	that's neat !
110 ↗	(On Diff #43800)	Please comment that GENESIS is guaranteed to be at first position and this is checked during the coloring step
346 ↗	(On Diff #43800)	nit: you can avoid the flag variable
chronik/chronik-db/src/io/token/io.rs
118 ↗	(On Diff #43800)	that's unusual
chronik/chronik-db/src/io/token/tests/mock.rs
1 ↗	(On Diff #43800)	missing copyright

This revision now requires changes to proceed.Jan 2 2024, 19:36

update copyrights to 2024, add BURN tests and add a comment about GENESIS for has_any_genesis

Harbormaster completed remote builds in B26156: Diff 43902.Jan 4 2024, 21:28

Put this on hold while we resolve the mint vault spec…

Discussion with Cyprian concluded, and the spec will match our implementation here.

Fabien accepted this revision.Jan 5 2024, 09:19

This revision is now accepted and ready to land.Jan 5 2024, 09:19

Closed by commit rABC79026e75747f: [Chronik] Add `TokenWriter` and `TokenReader` (authored by tobias_ruck). · Explain WhyJan 5 2024, 10:03

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC79026e75747f: [Chronik] Add `TokenWriter` and `TokenReader`.

[Chronik] Add `TokenWriter` and `TokenReader`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 43790

Cargo.lock

chronik/bitcoinsuite-slp/src/token_tx.rs

chronik/chronik-db/Cargo.toml

chronik/chronik-db/src/db.rs

chronik/chronik-db/src/io/mod.rs

chronik/chronik-db/src/io/token/batch.rs

chronik/chronik-db/src/io/token/data.rs

chronik/chronik-db/src/io/token/io.rs

chronik/chronik-db/src/io/token/mod.rs

chronik/chronik-db/src/io/token/tests/mod.rs

chronik/chronik-db/src/io/token/tests/test_batch.rs

chronik/chronik-db/src/io/txs.rs

[Chronik] Add `TokenWriter` and `TokenReader`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43790

Cargo.lock

chronik/bitcoinsuite-slp/src/token_tx.rs

chronik/chronik-db/Cargo.toml

chronik/chronik-db/src/db.rs

chronik/chronik-db/src/io/mod.rs

chronik/chronik-db/src/io/token/batch.rs

chronik/chronik-db/src/io/token/data.rs

chronik/chronik-db/src/io/token/io.rs

chronik/chronik-db/src/io/token/mod.rs

chronik/chronik-db/src/io/token/tests/mod.rs

chronik/chronik-db/src/io/token/tests/test_batch.rs

chronik/chronik-db/src/io/txs.rs

[Chronik] Add `TokenWriter` and `TokenReader`
ClosedPublic
Actions

Revision Contents
Changeset List