Differential D15069
[Chronik] Send regular pings from WebSocket to prevent disconnects Authored by tobias_ruck on Jan 3 2024, 15:31.
Details
This sends regular Ping messages from the websocket to keep the connection alive. From empicial testing, it seems like 45s is a good number to keep the connection alive for both browser and NodeJS WebSocket connections. We have to add a ChronikSettings to tune WS connection, because so far all configs were for the indexer only, but not for the HTTP/WS side of Chronik. ./test/functional/test_runner.py chronik_ws_ping
Diff Detail
Event TimelineComment Actions Tail of the build log: > tsc added 258 packages, and audited 259 packages in 7s 48 packages are looking for funding run `npm fund` for details found 0 vulnerabilities > chronik-client@0.10.0 integration-tests > mocha -j1 -r ts-node/register test/integration/*.ts --reporter mocha-junit-reporter --reporter-options mochaFile=test_results/chronik-client-integration-tests-junit.xml --reporter-options testsuitesTitle=Chronik Client Integration Tests --reporter-options rootSuiteTitle=Chronik Client Starting test_runner Test runner started 2024-01-03T15:56:02.515000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20240103_155602/setup_scripts/chronik-client_blockchain_info_0 Setting chronik url to http://127.0.0.1:30001 2024-01-03T15:56:04.469000Z TestFramework (INFO): Step 1: Mine 10 more blocks 2024-01-03T15:56:04.478000Z TestFramework (INFO): Received a stop message, exiting 2024-01-03T15:56:04.529000Z TestFramework (INFO): Stopping nodes 2024-01-03T15:56:04.982000Z TestFramework (INFO): Cleaning up /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20240103_155602/setup_scripts/chronik-client_blockchain_info_0 on exit 2024-01-03T15:56:04.982000Z TestFramework (INFO): Tests successful Running Unit Tests for Test Framework Modules [1msetup_scripts/chronik-client_blockchain_info.py[0m started [1msetup_scripts/chronik-client_blockchain_info.py[0m passed, Duration: 3 s [1m TEST | STATUS | DURATION [0m[0;32msetup_scripts/chronik-client_blockchain_info.py | ✓ Passed | 3 s [0m[1m ALL | ✓ Passed | 3 s (accumulated) [0mRuntime: 3 s -----------------------|---------|----------|---------|---------|----------------------------------- File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s -----------------------|---------|----------|---------|---------|----------------------------------- All files | 5.36 | 0.63 | 1.47 | 5.34 | chronik-client | 100 | 100 | 100 | 100 | index.ts | 100 | 100 | 100 | 100 | chronik-client/proto | 4.9 | 0.67 | 1.72 | 4.89 | chronik.ts | 5.44 | 0.84 | 1.81 | 5.42 | ...,3978-3985,3990-4027,4031-4036 chronikNode.ts | 4.15 | 0.45 | 1.59 | 4.17 | ...,2682-2729,2740-2804,2808-2813 chronik-client/src | 8.51 | 0 | 0 | 8.46 | ChronikClient.ts | 4.19 | 0 | 0 | 4.24 | 29-159,174-218,296-699 ChronikClientNode.ts | 40 | 100 | 0 | 40 | 23-42 failoverProxy.ts | 3.92 | 0 | 0 | 4.04 | 27-311 hex.ts | 31.57 | 0 | 0 | 33.33 | 30-34,38-42,46-59,63-65 -----------------------|---------|----------|---------|---------|----------------------------------- ##teamcity[blockOpened name='Code Coverage Summary'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='156'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='2909'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='21'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='3286'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='8'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='541'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='154'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='2881'] ##teamcity[blockClosed name='Code Coverage Summary'] Build chronik-client-integration-tests failed with exit code 1 Comment Actions I don't know what is causing this failure, something returns non zero despite everything seems to succeed... Comment Actions Can we make the interval much shorter on regtest ? It's sad the test has to last > 45s for no reason
Comment Actions If we reduce the ping timer on regtest, shall we also remove the pings coming from the test framework? Comment Actions Even if I don't think it hurts, it's probably no longer necessary. We can still use it to detect disconnects but that's unlikely to be useful in the test framework
| ||||||||||||||||||||