Differential D15097

refactor: Replace global find_value function with UniValue::find_value method
ClosedPublic
Actions

Authored by Fabien on Jan 5 2024, 15:33.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCb73fa52257e8: refactor: Replace global find_value function with UniValue::find_value method

Summary

These warning are very noisy and annoying when working on large refactors, hiding the useful information from the developer.

Backport of core#27605.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR27605

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26181
Build 51934: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 51933: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 5 2024, 15:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2024, 15:33

Fabien requested review of this revision.Jan 5 2024, 15:33

teamcity edited the summary of this revision. (Show Details)Jan 5 2024, 15:33

Harbormaster completed remote builds in B26181: Diff 43941.Jan 5 2024, 15:50

PiRK accepted this revision.Jan 5 2024, 16:00

This revision is now accepted and ready to land.Jan 5 2024, 16:00

Closed by commit rABCb73fa52257e8: refactor: Replace global find_value function with UniValue::find_value method (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>, committed by Fabien). · Explain WhyJan 5 2024, 16:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb73fa52257e8: refactor: Replace global find_value function with UniValue::find_value method.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

20 lines

httprpc.cpp

4 lines

qt/

rpcconsole.cpp

6 lines

rpc/

avalanche.cpp

10 lines

mining.cpp

6 lines

rawtransaction.cpp

2 lines

rawtransaction_util.cpp

10 lines

request.cpp

6 lines

util.cpp

10 lines

test/

6 lines

16 lines

2 lines

36 lines

univalue/

include/

univalue.h

6 lines

lib/

univalue.cpp

11 lines

wallet/

rpcwallet.cpp

2 lines

Diff 43941

View Options

src/bitcoin-cli.cpp

View Options

src/httprpc.cpp

View Options

src/qt/rpcconsole.cpp

View Options

src/rpc/avalanche.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/request.cpp

View Options

src/rpc/util.cpp

View Options

src/test/interfaces_tests.cpp

View Options

src/test/key_io_tests.cpp

View Options

src/test/rpc_server_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/univalue/include/univalue.h

View Options

src/univalue/lib/univalue.cpp

View Options

refactor: Replace global find_value function with UniValue::find_value methodClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43941

src/bitcoin-cli.cpp

src/httprpc.cpp

src/qt/rpcconsole.cpp

src/rpc/avalanche.cpp

src/rpc/mining.cpp

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/request.cpp

src/rpc/util.cpp

src/test/interfaces_tests.cpp

src/test/key_io_tests.cpp

src/test/rpc_server_tests.cpp

src/test/rpc_tests.cpp

src/univalue/include/univalue.h

src/univalue/lib/univalue.cpp

src/wallet/rpcwallet.cpp

refactor: Replace global find_value function with UniValue::find_value method
ClosedPublic
Actions

Revision Contents
Changeset List