Page MenuHomePhabricator

[Cashtab] Add function to generate burn targetOutputs
ClosedPublic

Authored by bytesofman on Jan 5 2024, 18:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe4e6f0954be9: [Cashtab] Add function to generate burn targetOutputs
Summary

Add function intended to deprecate cashMethods generateBurnOpReturn as part of transaction construction refactors

This diff does not yet implement the function

Test Plan

npm test

Diff Detail

Event Timeline

bytesofman published this revision for review.Jan 5 2024, 18:27

..TIL

For now, main idea is to deprecate the complicated tx building functions / tests in Cashtab and replace them with simpler ones that clearly maintain the same functionality. I would like to add explicit OP_RETURN script generators, like those in the badger fork of Cashtab, and lose the slp-mdm library -- then, why not explicit burn?

But I think this should happen after the transaction functions are cleaned up.

..TIL

For now, main idea is to deprecate the complicated tx building functions / tests in Cashtab and replace them with simpler ones that clearly maintain the same functionality. I would like to add explicit OP_RETURN script generators, like those in the badger fork of Cashtab, and lose the slp-mdm library -- then, why not explicit burn?

But I think this should happen after the transaction functions are cleaned up.

OK as a transition step but slp-mdm really is 328 lines of code including some code redundant with existing code in our repo. It can be removed easily by implementing our own set of functions. Also slp-mdm last version is 0.0.7 and it's already 3 years old, so unlikely to be maintained (even if it's simple enough that it should not require a lot of maintenance)

This revision is now accepted and ready to land.Jan 8 2024, 09:55