Add support and unit tests for blocks() method
Depends on D15210
Details
Details
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cc-node-block
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Event Timeline
Comment Actions
You're missing a test for end height > start height
| modules/chronik-client/README.md | ||
|---|---|---|
| 90 ↗ | (On Diff #44379) | See related comment in D15210 |
| modules/chronik-client/src/ChronikClientNode.ts | ||
| 52 ↗ | (On Diff #44379) | layout |
| modules/chronik-client/test/integration/block_and_blocks.ts | ||
| 48 ↗ | (On Diff #44379) | See related comment in D15210 |
| 118 ↗ | (On Diff #44379) | Please check the height (and prevhash if possible) in a loop to make sure you're getting contiguous blocks and the expected range, this test would pass if given heights 200, 150 and 42. |
| 131 ↗ | (On Diff #44379) | See relevant comment from D15210 |
Comment Actions
Failed tests logs:
====== /block and /blocks: "before each" hook for "gives us the block after parking the last block and throws expected error attempting to get parked block"./block and /blocks "before each" hook for "gives us the block after parking the last block and throws expected error attempting to get parked block" ======
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/block_and_blocks.ts)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)Each failure log is accessible here:
/block and /blocks: "before each" hook for "gives us the block after parking the last block and throws expected error attempting to get parked block"./block and /blocks "before each" hook for "gives us the block after parking the last block and throws expected error attempting to get parked block"
Comment Actions
the dep stack was messed up during a rebase, not able to reconstruct.
Will have it all in D15210