Page MenuHomePhabricator

[electrum] fix cashaddr prefix for fulcrum donation address
ClosedPublic

Authored by PiRK on Jan 23 2024, 16:29.

Details

Summary

We no longer support the "bitcoincash:" prefix, so if a user clicks on "Help > Donate to server" while connected to a server that advertises the default donation address, it causes an error. Fix this by converting the address explicitely to an "ecash:" address.

Fix also two prefixes in comments.

Depends on D15250

Test Plan

Connect to a server that does not specify a custom donation address (electrum.bitcoinabc.org) and click the "Help > Donate to server" menu action. Check that it does not raise an error message.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bip21_multi_outputs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26587
Build 52744: Build Diffelectrum-tests
Build 52743: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Jan 23 2024, 16:29
bytesofman added a subscriber: bytesofman.

I'm not able to arc patch this, cherry picking error likely from need for rebase

This revision now requires changes to proceed.Jan 24 2024, 00:32

rebase.
Not sure if this will fix the arc patch issue, I cannot reproduce (likely because I have some commits locally that make it work)

This revision is now accepted and ready to land.Jan 24 2024, 14:33