Page MenuHomePhabricator
Differential D15251

[electrum] fix cashaddr prefix for fulcrum donation address
ClosedPublic
Actions

Authored by PiRK on Jan 23 2024, 16:29.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Commits
rABCd0ffa30ed29d: [electrum] fix cashaddr prefix for fulcrum donation address
Summary

We no longer support the "bitcoincash:" prefix, so if a user clicks on "Help > Donate to server" while connected to a server that advertises the default donation address, it causes an error. Fix this by converting the address explicitely to an "ecash:" address.

Fix also two prefixes in comments.

Depends on D15250

Test Plan

Connect to a server that does not specify a custom donation address (electrum.bitcoinabc.org) and click the "Help > Donate to server" menu action. Check that it does not raise an error message.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 23 2024, 16:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2024, 16:29
PiRK requested review of this revision.Jan 23 2024, 16:29
PiRK edited the summary of this revision. (Show Details)Jan 23 2024, 16:30
Fabien edited the summary of this revision. (Show Details)Jan 23 2024, 16:35
Fabien added a parent revision: D15250: [electrum] support parsing multi-output URIs.
Harbormaster completed remote builds in B26583: Diff 44488.Jan 23 2024, 16:36
PiRK updated this revision to Diff 44497.Jan 23 2024, 20:58

rebase

Harbormaster completed remote builds in B26587: Diff 44497.Jan 23 2024, 21:00
bytesofman requested changes to this revision.Jan 24 2024, 00:32
bytesofman added a subscriber: bytesofman.

I'm not able to arc patch this, cherry picking error likely from need for rebase

This revision now requires changes to proceed.Jan 24 2024, 00:32
PiRK updated this revision to Diff 44518.Jan 24 2024, 08:05

rebase.
Not sure if this will fix the arc patch issue, I cannot reproduce (likely because I have some commits locally that make it work)

Harbormaster completed remote builds in B26608: Diff 44518.Jan 24 2024, 08:07
Fabien accepted this revision.Jan 24 2024, 09:09
bytesofman accepted this revision.Jan 24 2024, 14:33
This revision is now accepted and ready to land.Jan 24 2024, 14:33
Closed by commit rABCd0ffa30ed29d: [electrum] fix cashaddr prefix for fulcrum donation address (authored by PiRK). · Explain WhyJan 24 2024, 15:32
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd0ffa30ed29d: [electrum] fix cashaddr prefix for fulcrum donation address.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_gui/
qt/
8 lines

Diff 44536

View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...