[Cashtab] Add github link to social icons on Settings page
ClosedPublic
Actions

Authored by bytesofman on Jan 25 2024, 18:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC36df1db214aa: [Cashtab] Add github link to social icons on Settings page

Summary

Add link to cashtab dir at mirrored bitcoinabc github

Test Plan

npm start and confirm it's there, working, looks ok

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add-github-link

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26658
Build 52884: Build Diff	cashtab-tests
Build 52883: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 25 2024, 18:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2024, 18:12

Harbormaster completed remote builds in B26657: Diff 44596.Jan 25 2024, 18:12

use the right icon

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

/work/cashtab /work/abc-ci-builds/cashtab-tests

added 1930 packages, and audited 1931 packages in 36s

264 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

> cashtab@1.0.2 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/components/Common/CustomIcons.js
  Line 18:5:  'GithubOutlined' is defined but never used  no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

Harbormaster completed remote builds in B26658: Diff 44597.Jan 25 2024, 18:15

better spacing

bytesofman edited the test plan for this revision. (Show Details)Jan 25 2024, 18:17

bytesofman published this revision for review.Jan 25 2024, 18:32

Harbormaster completed remote builds in B26659: Diff 44598.Jan 25 2024, 18:32

Fabien accepted this revision.Jan 26 2024, 09:58

This revision is now accepted and ready to land.Jan 26 2024, 09:58

Closed by commit rABC36df1db214aa: [Cashtab] Add github link to social icons on Settings page (authored by bytesofman). · Explain WhyJan 26 2024, 11:40

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC36df1db214aa: [Cashtab] Add github link to social icons on Settings page.