Page MenuHomePhabricator

[Cashtab] Add github link to social icons on Settings page
ClosedPublic

Authored by bytesofman on Jan 25 2024, 18:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC36df1db214aa: [Cashtab] Add github link to social icons on Settings page
Summary

Add link to cashtab dir at mirrored bitcoinabc github

Test Plan

npm start and confirm it's there, working, looks ok

image.png (548×518 px, 29 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tail of the build log:

/work/cashtab /work/abc-ci-builds/cashtab-tests

added 1930 packages, and audited 1931 packages in 36s

264 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

> cashtab@1.0.2 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/components/Common/CustomIcons.js
  Line 18:5:  'GithubOutlined' is defined but never used  no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1
This revision is now accepted and ready to land.Jan 26 2024, 09:58