Wallets with aliases in contact list currently throw the list out and do not set to context. Patch this.
Migrate legacy tests to vectors to improve readability. Add new vector for alias case.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC3c75da4a6bd0: [Cashtab] Improve isValidContactList function and tests
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- patch-nocontactlist-bug
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26802 Build 53172: Build Diff cashtab-tests Build 53171: arc lint + arc unit
Event Timeline
Comment Actions
Wallets with aliases in contact list currently throw the list out and do not set to context.
I'm not seeing the part where it's throwing out the list nor how it's patched to be set to context in this diff. Is there a part 2 to this stack?
Comment Actions
see inline comments
there's a separate issue here in that the Configure page is getting contact list from local forage, and not wallet context -- so it renders everything just fine. this should be patched after we get this fix in (which allows useWallet.js to set the localforage contactList to wallet context).
but a wallet with aliases in contact list will not show contacts rendered in tx history.
| cashtab/src/validation/fixtures/vectors.js | ||
|---|---|---|
| 633 ↗ | (On Diff #44803) | here is the new test |
| cashtab/src/validation/index.js | ||
| 306 ↗ | (On Diff #44803) | chicken.xec will fail this test but pas after the change at right |