Page MenuHomePhabricator

[electrum] rename scripts with .py extension, and fix misc lint errors
ClosedPublic

Authored by PiRK on Feb 1 2024, 14:18.

Details

Summary

With the .py extension, these files will now be under the watch of our linters.

Fix two remaing linter issues: a missing #!/usr/bin/env python3 shebang and a missing encoding when calling open(...)

Depends on D15359

Test Plan

contrib/source-control-tools/patch-recipes/update-electrum-checkpoints.sh

arc lint -- electrum/scripts/*py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
get_merkle_root_verbosity
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26847
Build 53262: Build Diffelectrum-tests
Build 53261: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Feb 1 2024, 14:18

include previously uncommited change to update-electrum-checkpoints.py

Note that get_merkle_root.py is the only one of these scripts that has a practical application. The other ones are kept as useful code samples/examples. There are Electrum ABC command-line commands equivalents for each of these use cases.

This revision is now accepted and ready to land.Feb 1 2024, 15:07