Page MenuHomePhabricator
Differential D15360

[Cashtab] Update SendXec with direct calls to antd notifications
ClosedPublic
Actions

Authored by emack on Feb 1 2024, 12:25.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCb267ab21d00d: [Cashtab] Update SendXec with direct calls to antd notifications
Summary

This diff deprecates sendXecNotification and updates SendXec.js to call on the antd component directly.

Notification unit test already covered under SendXec.test.js' Clicking "Send" will send a valid tx with op_return_raw after entry of a valid address and bip21 query string with valid amount and op_return_raw params to Send To field test.

Test Plan
  • grep -r sendXecNotification src/ with no output
  • npm test
  • npm start
  • success notif: send a one to one XEC tx (no change to notification UI)
  • error notif: send a one to many XEC tx with an amount larger than balance

image.png (290×403 px, 17 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendXecNotifs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26866
Build 53299: Build Diffcashtab-tests
Build 53298: arc lint + arc unit

Event Timeline

emack created this revision.Feb 1 2024, 12:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2024, 12:25
emack requested review of this revision.Feb 1 2024, 12:25
emack edited the test plan for this revision. (Show Details)Feb 1 2024, 12:26
Harbormaster completed remote builds in B26833: Diff 44846.Feb 1 2024, 12:33
bytesofman added a comment.Feb 1 2024, 13:28

error notif: send a one to many XEC tx with an amount larger than balance

unrelated but we should be catching this in validation

bytesofman requested changes to this revision.Feb 1 2024, 13:30
bytesofman added inline comments.
cashtab/src/components/Send/SendXec.js
418–421 ↗(On Diff #44846)
510–525 ↗(On Diff #44846)

don't define a var if we only use it one time

This revision now requires changes to proceed.Feb 1 2024, 13:30
emack updated this revision to Diff 44858.Feb 1 2024, 14:10
emack marked 2 inline comments as done.

Updated var assignments

Harbormaster completed remote builds in B26844: Diff 44858.Feb 1 2024, 14:14
bytesofman accepted this revision.Feb 1 2024, 17:36
This revision is now accepted and ready to land.Feb 1 2024, 17:36
emack updated this revision to Diff 44885.Feb 2 2024, 00:52

version bump

Harbormaster completed remote builds in B26866: Diff 44885.Feb 2 2024, 00:55
Closed by commit rABCb267ab21d00d: [Cashtab] Update SendXec with direct calls to antd notifications (authored by emack). · Explain WhyFeb 2 2024, 00:56
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABCb267ab21d00d: [Cashtab] Update SendXec with direct calls to antd notifications.

Revision Contents
Changeset List

PathSize
cashtab/
2 lines
src/
components/
Common/
20 lines
Send/
43 lines

Diff 44885

View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Common/Notifications.js

Loading...
View Options

cashtab/src/components/Send/SendXec.js

Loading...