Revert "Remove unecessary header in amount.h"
ClosedPublic
Actions

Authored by schancel on Aug 6 2018, 15:08.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe10cafb55058: Revert "Remove unecessary header in amount.h"
rABCe10cafb55058: Revert "Remove unecessary header in amount.h"

Summary

This reverts commit ffd121e24b842daee2a11e64eb1c750d80599ecf.
This header is neccessary to compile on MacOS X.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

revert-D1617

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3028
Build 4149: Bitcoin ABC Buildbot (legacy)
Build 4148: arc lint + arc unit

Event Timeline

schancel created this revision.Aug 6 2018, 15:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2018, 15:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Aug 6 2018, 15:13

This revision is now accepted and ready to land.Aug 6 2018, 15:13

Add extra info

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3027: Diff 4512.Aug 6 2018, 15:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3028: Diff 4513.Aug 6 2018, 15:55

Looks good to me. I also opened a task to figure this out: https://reviews.bitcoinabc.org/T391 Assigned to Nico since he'll likely be looking into header cleanup in the future.

Closed by commit rABCe10cafb55058: Revert "Remove unecessary header in amount.h" (authored by schancel). · Explain WhyAug 6 2018, 17:02

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

amount.h

4 lines

Diff 4513

View Options

Revert "Remove unecessary header in amount.h"ClosedPublicActions