Page MenuHomePhabricator
Differential D1626

code formatting for transaction.cpp
ClosedPublic
Actions

Authored by andychen on Aug 6 2018, 02:24.

Details

Reviewers
schancel
jasonbcox
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rSTAGINGc21f4f32d8c6: code formatting for transaction.cpp
rABCc21f4f32d8c6: code formatting for transaction.cpp
Summary

as title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
code_formatting/transaction
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3034
Build 4161: Bitcoin ABC Buildbot (legacy)
Build 4160: arc lint + arc unit

Event Timeline

andychen created this revision.Aug 6 2018, 02:24
Owners added a reviewer: Restricted Owners Package.Aug 6 2018, 02:24
teamcity added a subscriber: teamcity.Aug 6 2018, 02:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3026: Diff 4511.Aug 6 2018, 03:06
teamcity added a comment.Aug 6 2018, 03:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Aug 6 2018, 15:12
This revision is now accepted and ready to land.Aug 6 2018, 15:12
schancel added a comment.Aug 6 2018, 17:14

Looks great. Thanks @andychen

src/primitives/transaction.cpp
106 ↗(On Diff #4511)

We can probably do C++11 loop here too?

127 ↗(On Diff #4511)

C++11 style loops would be great.

jasonbcox requested changes to this revision.Aug 6 2018, 23:03
jasonbcox added inline comments.
src/primitives/transaction.cpp
130 ↗(On Diff #4511)

C++11 style loop would work here as well

This revision now requires changes to proceed.Aug 6 2018, 23:03
andychen updated this revision to Diff 4523.Aug 7 2018, 04:50

C++11 loop style

teamcity added a comment.Aug 7 2018, 04:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 7 2018, 05:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3034: Diff 4523.Aug 7 2018, 05:32
jasonbcox accepted this revision.Aug 7 2018, 14:42
This revision is now accepted and ready to land.Aug 7 2018, 14:42
Closed by commit rABCc21f4f32d8c6: code formatting for transaction.cpp (authored by andychen). · Explain WhyAug 7 2018, 15:33
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
primitives/
30 lines

Diff 4523

View Options

src/primitives/transaction.cpp

Loading...