Page MenuHomePhabricator

[Cashtab] Update airdrop.js with direct antd calls
ClosedPublic

Authored by emack on Feb 16 2024, 13:23.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC58a837932d0a: [Cashtab] Update airdrop.js with direct antd calls
Summary

Replacing Notification.js usage with direct antd API calls at callsite.

As per tg discussion, not creating integration test to retest existing functionality until we have a diff that changes the component. Using manual tests for now.

Test Plan
  • Navigate to Airdrop
  • Calculate an airdrop with Minimum eToken holder balance set to a large number
  • Ensure error notification No holders found for eToken ID: (token ID) is rendered
  • Create a new token
  • Attempt to calculate an airdrop for the new token (with no holders) and ensure error notification.
  • Malform config/token.js/tokenDbUrl and ensure error notification.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
airdropNotif
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27190
Build 53946: Build Diffcashtab-tests
Build 53945: arc lint + arc unit

Event Timeline

emack published this revision for review.Feb 16 2024, 13:25
emack added a reviewer: bytesofman.
bytesofman added inline comments.
cashtab/package-lock.json
9 ↗(On Diff #45302)

rebase and version bump

This revision is now accepted and ready to land.Feb 16 2024, 13:50

Rebase and version bump