Page MenuHomePhabricator
Differential D15476

[Cashtab] Update incoming txs with direct calls to antd
ClosedPublic
Actions

Authored by emack on Feb 17 2024, 23:41.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCf8d0931e35e3: [Cashtab] Update incoming txs with direct calls to antd
Summary

Update the incoming XEC and eToken tx notifs to call antd from callsite instead of from Notification.js.

Test Plan
  • Receive an XEC tx
  • Receive an eToken that has an existing balance on wallet
  • Receive an eToken that has no existing balance on wallet

Diff Detail

Repository
rABC Bitcoin ABC
Branch
receiveNotifs
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 27226
Build 54015: Build Diffcashtab-tests
Build 54014: arc lint + arc unit

Event Timeline

emack created this revision.Feb 17 2024, 23:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 17 2024, 23:41
Harbormaster completed remote builds in B27226: Diff 45353.Feb 17 2024, 23:44
emack updated this revision to Diff 45374.Feb 19 2024, 05:27

version bump and linting changes

Harbormaster completed remote builds in B27245: Diff 45374.Feb 19 2024, 05:32
emack published this revision for review.Feb 19 2024, 05:33
emack added a reviewer: bytesofman.
bytesofman accepted this revision.Feb 19 2024, 21:34
bytesofman added inline comments.
cashtab/package-lock.json
3 ↗(On Diff #45374)

rebase and version bump

cashtab/src/hooks/useWallet.js
884 ↗(On Diff #45374)
921 ↗(On Diff #45374)

comment is now obsolete

This revision is now accepted and ready to land.Feb 19 2024, 21:34
emack updated this revision to Diff 45412.Feb 20 2024, 08:39
emack marked 3 inline comments as done.

Rebase, version bump and commenting updates

Harbormaster completed remote builds in B27272: Diff 45412.Feb 20 2024, 09:13
Closed by commit rABCf8d0931e35e3: [Cashtab] Update incoming txs with direct calls to antd (authored by emack). · Explain WhyFeb 20 2024, 09:17
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABCf8d0931e35e3: [Cashtab] Update incoming txs with direct calls to antd.

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
2 lines
src/
components/
Common/
80 lines
hooks/
109 lines

Diff 45353

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Common/Notifications.js

Loading...
View Options

cashtab/src/hooks/useWallet.js

Loading...