Page MenuHomePhabricator

[Cashtab] Delete all functions, files, and mocks related to legacy tx building
ClosedPublic

Authored by bytesofman on Feb 24 2024, 23:35.

Details

Summary

Cashtab now creates all txs using ecash-coinselect and unit-tested targetOutput building functions.

The legacy functions were tied together in many unit tests making it impractical to delete them in line with progress on the upgraded methods.

Now, though, they aren't used anywhere.

Test Plan

npm test
arc lint confirms these deleted functions aren't called anywhere else, plus deleted mocks not used anywhere else

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-cleanup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27396
Build 54355: Build Diffcashtab-tests
Build 54354: arc lint + arc unit