Page MenuHomePhabricator
Differential D1650

Update macOS build to use correct versions of dependencies
AbandonedPublic
Actions

Authored by akb on Aug 13 2018, 19:42.

Details

Reviewers
schancel
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Specify OpenSSL 1.1 when checking homebrew for fs location
Use BerkeleyDB > 4 when building on macOS

Test Plan

Build should succeed on macOS

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-macos-brew-versions
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3074
Build 4236: Bitcoin ABC Buildbot (legacy)
Build 4235: arc lint + arc unit

Event Timeline

akb created this revision.Aug 13 2018, 19:42
Owners added a reviewer: Restricted Owners Package.Aug 13 2018, 19:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 13 2018, 19:42
teamcity added a subscriber: teamcity.Aug 13 2018, 19:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 13 2018, 20:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3074: Diff 4578.Aug 13 2018, 20:21
jasonbcox added a subscriber: jasonbcox.Aug 13 2018, 20:36

Please hold off on this until after our release on Wednesday. We're trying to reduce the chance of build-breaking changes until then.

akb added reviewers: schancel, jasonbcox.Aug 20 2018, 18:17
schancel accepted this revision.Aug 20 2018, 20:12
This revision is now accepted and ready to land.Aug 20 2018, 20:12
schancel requested changes to this revision.Aug 20 2018, 20:15

Actually, can you verify the OSX cross compilation is using berkeleydb5.3? We don't want official builds using >5.3 due to licensing.

This revision now requires changes to proceed.Aug 20 2018, 20:15
akb added a comment.EditedAug 21 2018, 18:12
In D1650#34928, @schancel wrote:

Actually, can you verify the OSX cross compilation is using berkeleydb5.3? We don't want official builds using >5.3 due to licensing.

Cross-compilation is pulling in 5.3 for macOS.

Edit: Misspoke, didn't know about the dependency cross-compilation

akb abandoned this revision.Nov 11 2018, 03:48

Revision Contents
Changeset List

PathSize
4 lines
doc/
2 lines

Diff 4578

View Options

configure.ac

Loading...
View Options

doc/build-osx.md

Loading...