Page MenuHomePhabricator

[Chronik] Remove lifetime from `MemberSer` in `Group`
ClosedPublic

Authored by tobias_ruck on Mar 3 2024, 23:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc79efae644a2: [Chronik] Remove lifetime from `MemberSer` in `Group`
Summary

Serializations use owned types like Bytes or [u8; 32] anyway, so it's currently unused, and removing the lifetime allows us to directly store serialized objects e.g. in a cache.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-remove-ser-member-lifetime
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27623
Build 54809: Build Diffchronik-client-integration-tests · build-chronik-plugins · build-chronik
Build 54808: arc lint + arc unit

Event Timeline

Failed tests logs:

====== Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool" ======
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/token_slp_nft1.ts)
    at listOnTimeout (node:internal/timers:573:17)
    at processTimers (node:internal/timers:514:7)

Each failure log is accessible here:
Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool"

This revision is now accepted and ready to land.Mar 4 2024, 08:57