Page MenuHomePhabricator
Differential D1668

Make sure we do not drop transactions during reorg when the don't come in topological order.
ClosedPublic
Actions

Authored by deadalnix on Aug 23 2018, 23:17.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING904931e89007: Make sure we do not drop transactions during reorg when the don't come in…
rABC904931e89007: Make sure we do not drop transactions during reorg when the don't come in…
Summary

AcceptToMemoryPool expecttransaction to be passed in one by one in topological order. As a result, many transaction gets rejected because input are not available.

The obvious long term solution is to refactor memory pool acceptance, but in the meantime, we can ensure topological order when we reinsert transactions in the mempool after reorgs.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
reorgkeeptxn
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3109
Build 4305: Bitcoin ABC Buildbot (legacy)
Build 4304: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 23 2018, 23:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 23 2018, 23:17
deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Aug 23 2018, 23:17
deadalnix updated this revision to Diff 4624.Aug 23 2018, 23:20

Fix typo

deadalnix updated this revision to Diff 4626.Aug 23 2018, 23:24

Rebase on top of D1667

jasonbcox accepted this revision.Aug 23 2018, 23:33
jasonbcox added a subscriber: jasonbcox.

Please fix the typos before landing

src/txmempool.cpp
1289 ↗(On Diff #4623)

If -> In
ordering -> order

1290 ↗(On Diff #4623)

paretn -> parent

1296 ↗(On Diff #4623)

nothign -> nothing

This revision is now accepted and ready to land.Aug 23 2018, 23:33
deadalnix updated this revision to Diff 4628.Aug 23 2018, 23:38

typos

deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Aug 23 2018, 23:38
Closed by commit rABC904931e89007: Make sure we do not drop transactions during reorg when the don't come in… (authored by deadalnix). · Explain WhyAug 23 2018, 23:38
This revision was automatically updated to reflect the committed changes.
teamcity added a subscriber: teamcity.Aug 23 2018, 23:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 23 2018, 23:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3106: Diff 4623.Aug 23 2018, 23:56
teamcity added a comment.Aug 23 2018, 23:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3107: Diff 4624!Aug 23 2018, 23:59
teamcity added a comment.Aug 24 2018, 00:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3109: Diff 4626!Aug 24 2018, 00:03
teamcity added a comment.Aug 24 2018, 00:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3110: Diff 4628.Aug 24 2018, 00:16

Revision Contents
Changeset List

PathSize
src/
2 lines
45 lines
test/
functional/
2 lines

Diff 4626

View Options

src/miner.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

test/functional/abc-transaction-ordering.py

Loading...