Page MenuHomePhabricator

Make function manipulating DisconnectedBlockTransactions member functions
ClosedPublic

Authored by deadalnix on Aug 23 2018, 21:46.

Details

Summary

This ensures that the innards can be kept private.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox requested changes to this revision.Aug 23 2018, 23:19
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/txmempool.cpp
1269 ↗(On Diff #4622)

Seems like this belongs in the header?

src/txmempool.h
840 ↗(On Diff #4622)

Should make private: explicit above this line

874 ↗(On Diff #4622)

whil -> while

src/validation.cpp
597 ↗(On Diff #4622)

This keeps getting linted for everyone touching this file. I say leave it in at this point.

This revision now requires changes to proceed.Aug 23 2018, 23:19
src/txmempool.cpp
1269 ↗(On Diff #4622)

Why ?

Fix typo, make private explicit.

jasonbcox added inline comments.
src/txmempool.cpp
1269 ↗(On Diff #4622)

I guess that's just a standard practice to have constants in headers. It makes them easier to find. It's technically correct either way.

This revision is now accepted and ready to land.Aug 23 2018, 23:34
src/txmempool.cpp
1269 ↗(On Diff #4622)

Except that if I change the value of the contant, I don't have to recompile half of the world.

This revision was automatically updated to reflect the committed changes.