Page MenuHomePhabricator
Differential D8977

[validation] Move validation-only consts to validation.cpp
ClosedPublic
Actions

Authored by PiRK on Jan 20 2021, 10:15.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6b3bb60ac35c: [validation] Move validation-only consts to validation.cpp
Summary

This is a backport of Core PR17383 [2/4]
https://github.com/bitcoin/bitcoin/pull/17383/commits/0109622b08887ed01a30911477ce4b8f266d4b4a
Depends on D8976

UNDOFILE_CHUNK_SIZE and BLOCKFILE_CHUNK_SIZE were moved to blockdb.h in
D7579
MAX_DISCONNECTED_TX_POOL_SIZE was moved to txmempool.h on D1667

MAX_FEE_ESTIMATION_TIP_AGE is unused since D2784

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 20 2021, 10:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2021, 10:15
PiRK requested review of this revision.Jan 20 2021, 10:15
teamcity edited the summary of this revision. (Show Details)Jan 20 2021, 10:15
Harbormaster completed remote builds in B14861: Diff 27109.Jan 20 2021, 10:18
teamcity added a comment.Jan 20 2021, 10:18
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[326/499] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[327/499] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[328/499] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[329/499] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[330/499] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[331/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[332/499] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[333/499] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[334/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[335/499] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[336/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[337/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[338/499] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[339/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[340/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[341/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[342/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[343/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[344/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[345/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[346/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[347/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[348/499] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[349/499] Linking CXX static library src/libutil.a
[350/499] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[351/499] Linking CXX static library src/librpcclient.a
[352/499] Linking CXX static library src/libbitcoinconsensus.a
[353/499] Linking CXX static library src/libscript.a
[354/499] Linking CXX static library src/libcommon.a
[355/499] Linking CXX shared library src/libbitcoinconsensus.so.0.22.12
[356/499] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[357/499] Linking CXX executable src/bitcoin-cli
[358/499] Linking CXX executable src/bitcoin-tx
[359/499] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[360/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[361/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[362/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[363/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[364/499] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[365/499] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[366/499] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[367/499] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[368/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[369/499] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[370/499] Linking CXX static library src/zmq/libzmq.a
[371/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[372/499] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[373/499] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[374/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[375/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[376/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[377/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[378/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[379/499] Linking CXX static library src/wallet/libwallet.a
[380/499] Linking CXX static library src/wallet/libwallet-tool.a
[381/499] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
PiRK added a child revision: D8978: [validation] Move all const declarations to top of validation.h.Jan 20 2021, 10:21
Fabien requested changes to this revision.Jan 20 2021, 10:40
Fabien added a subscriber: Fabien.

Please investigate the error

This revision now requires changes to proceed.Jan 20 2021, 10:40
PiRK updated this revision to Diff 27114.Jan 20 2021, 10:56

remove unused const MAX_FEE_ESTIMATION_TIP_AGE. Its only use was deleted in D2784

PiRK edited the summary of this revision. (Show Details)Jan 20 2021, 10:57
PiRK mentioned this in D8980: [net processing] Move all const declarations to top of net_processing.cpp.Jan 20 2021, 11:01
Harbormaster completed remote builds in B14866: Diff 27114.Jan 20 2021, 11:09
Fabien accepted this revision.Jan 20 2021, 11:17
This revision is now accepted and ready to land.Jan 20 2021, 11:17
Closed by commit rABC6b3bb60ac35c: [validation] Move validation-only consts to validation.cpp (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyJan 20 2021, 14:48
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC6b3bb60ac35c: [validation] Move validation-only consts to validation.cpp.

Revision Contents
Changeset List

PathSize
src/
9 lines
5 lines

Diff 27131

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...