Page MenuHomePhabricator

[net processing] Move all const declarations to top of net_processing.cpp
ClosedPublic

Authored by PiRK on Jan 20 2021, 10:29.

Details

Summary
Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Jan 20 2021, 10:29

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[325/499] Linking C executable src/secp256k1/recover-bench
[326/499] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[327/499] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[328/499] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[329/499] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[330/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[331/499] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[332/499] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[333/499] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[334/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[335/499] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[336/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[337/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[338/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[339/499] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[340/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[341/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[342/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[343/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[344/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[345/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[346/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[347/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[348/499] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[349/499] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[350/499] Linking CXX static library src/libutil.a
[351/499] Linking CXX static library src/librpcclient.a
[352/499] Linking CXX static library src/libbitcoinconsensus.a
[353/499] Linking CXX static library src/libscript.a
[354/499] Linking CXX static library src/libcommon.a
[355/499] Linking CXX shared library src/libbitcoinconsensus.so.0.22.12
[356/499] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[357/499] Linking CXX executable src/bitcoin-cli
[358/499] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[359/499] Linking CXX executable src/bitcoin-tx
[360/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[361/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[362/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[363/499] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[364/499] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[365/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[366/499] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[367/499] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[368/499] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[369/499] Linking CXX static library src/zmq/libzmq.a
[370/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[371/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[372/499] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[373/499] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[374/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[375/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[376/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[377/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[378/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[379/499] Linking CXX static library src/wallet/libwallet.a
[380/499] Linking CXX static library src/wallet/libwallet-tool.a
[381/499] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

rebase after removing unused MAX_FEE_ESTIMATION_TIP_AGE in D8977 which caused build-clang to fail

This revision is now accepted and ready to land.Jan 20 2021, 12:48