Page MenuHomePhabricator

[validation] Move all const declarations to top of validation.h
ClosedPublic

Authored by PiRK on Jan 20 2021, 10:21.

Details

Summary
Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Jan 20 2021, 10:21

Tail of the build log:

[337/499] Linking C executable src/secp256k1/sign-bench
[338/499] Linking C executable src/secp256k1/verify-bench
[339/499] Linking C executable src/secp256k1/recover-bench
[340/499] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[341/499] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/clang++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wshadow -Wshadow-field -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wformat-security -Wredundant-move -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp:73:22: error: unused variable 'MAX_FEE_ESTIMATION_TIP_AGE' [-Werror,-Wunused-const-variable]
static const int64_t MAX_FEE_ESTIMATION_TIP_AGE = 3 * 60 * 60;
                     ^
1 error generated.
[342/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[343/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[344/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[345/499] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[346/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[347/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[348/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[349/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[350/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[351/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[352/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[353/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[354/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[355/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[356/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[357/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[358/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[359/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[360/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[361/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[362/499] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[363/499] Linking CXX static library src/wallet/libwallet.a
[364/499] Linking CXX static library src/wallet/libwallet-tool.a
[365/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[366/499] Linking CXX executable src/bitcoin-wallet
[367/499] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[368/499] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[369/499] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[370/499] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[371/499] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[372/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[373/499] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[374/499] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[375/499] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[376/499] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[377/499] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[378/499] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[379/499] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[380/499] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[381/499] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

rebase after removing unused MAX_FEE_ESTIMATION_TIP_AGE in D8977

This revision is now accepted and ready to land.Jan 20 2021, 12:46