Page MenuHomePhabricator

[net processing] Move net processing consts to net_processing.cpp
ClosedPublic

Authored by PiRK on Jan 20 2021, 09:57.

Details

Summary

Following the main.cpp split, there are still some constants in the wrong places, eg net_processing constants in validation.h. Move them all to their rightful homes. At the same time, make them constexpr.

Also move all const declarations to the top of their files, and ensure that they all have doxygen comments.

This is a backport of Core PR17383 [1/4]
https://github.com/bitcoin/bitcoin/pull/17383/commits/b8580cacc70764ba5a48e3defb864d75e6c28626

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Jan 20 2021, 09:57
Fabien requested changes to this revision.Jan 20 2021, 10:37
Fabien added a subscriber: Fabien.

The moves inside the validation.h header are missing

This revision now requires changes to proceed.Jan 20 2021, 10:37
PiRK requested review of this revision.Jan 20 2021, 11:04

Are you referring to the moves in D8978?

Yes, must have clicked full diff while looking at this single commit

This revision is now accepted and ready to land.Jan 20 2021, 11:13