Page MenuHomePhabricator
Differential D3293

Merge #13163: Make it clear which functions that are intended to be translation unit local
AbandonedPublic
Actions

Authored by nakihito on Jun 11 2019, 22:29.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Backport of Core PR13163
https://github.com/bitcoin/bitcoin/pull/13163/

Depends on D3285

Should be landed immediately after dependencies.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13163
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6542
Build 11131: Bitcoin ABC Buildbot (legacy)
Build 11130: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 11 2019, 22:29
Owners added a reviewer: Restricted Owners Package.Jun 11 2019, 22:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2019, 22:29
nakihito planned changes to this revision.Jun 11 2019, 22:29
teamcity added a comment.Jun 11 2019, 22:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6272: Diff 9329.Jun 11 2019, 22:38
teamcity added a comment.Jun 11 2019, 22:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

nakihito added a child revision: D3294: Merge #13291: test: Don't include torcontrol.cpp into the test file.Jun 11 2019, 22:41
nakihito edited the summary of this revision. (Show Details)Jun 11 2019, 22:42
nakihito mentioned this in D3283: Merge #10408, #13291, and partial #13163.Jun 11 2019, 22:44
nakihito added a comment.Jun 12 2019, 23:30

bench/prevector.cpp: https://reviews.bitcoinabc.org/D3061

bitcoin-cli.cpp: https://reviews.bitcoinabc.org/D3058

core_read.cpp change looks like witness code: https://github.com/bitcoin/bitcoin/pull/10481/files

Could not find where/when the code for the last change in init.cpp was removed, but I found a backport that would have touched it and the original Core PR that added it:
https://reviews.bitcoinabc.org/D2260
https://github.com/bitcoin/bitcoin/pull/5677

net.cpp: https://reviews.bitcoinabc.org/D1863

net_processing.cpp:
https://reviews.bitcoinabc.org/D1879
Last change is witness code

random.cpp: https://reviews.bitcoinabc.org/D1939

rpc/blockhcain.cpp: https://reviews.bitcoinabc.org/D2952

rpc/mining.cpp: https://reviews.bitcoinabc.org/D35

rpc/misc.cpp: https://reviews.bitcoinabc.org/D44#change-NtxAgEAFHeNl

rpc/net.cpp: https://reviews.bitcoinabc.org/D44#change-NtxAgEAFHeNl

rpc/rawtransaction.cpp
https://reviews.bitcoinabc.org/D3013#change-nhUnShmRryR1
https://reviews.bitcoinabc.org/D44#change-nhUnShmRryR1

rpc/server: https://reviews.bitcoinabc.org/D1039

src/test/blockchain_tests.cpp: https://reviews.bitcoinabc.org/D3012

src/test/checkqueue_tests.cpp: https://reviews.bitcoinabc.org/D1771

src/test/coins_tests.cpp: https://reviews.bitcoinabc.org/D515

src/test/versionbits_tests.cpp: https://reviews.bitcoinabc.org/D2783

src/validation.cpp:
https://reviews.bitcoinabc.org/D1667 updateMempoolForReorg moved to txmempool.cpp

src/wallet/rpcwallet.cpp:
https://reviews.bitcoinabc.org/D44#change-4q6XVS3POqj5
https://reviews.bitcoinabc.org/D1035
https://github.com/bitcoin/bitcoin/pull/12892/files last two functions added here

nakihito updated this revision to Diff 9779.Jun 28 2019, 17:17

Rebased.

teamcity added a comment.Jun 28 2019, 17:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 28 2019, 17:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6542: Diff 9779.Jun 28 2019, 17:25
nakihito planned changes to this revision.Jun 29 2019, 00:48

Going to try and break this into smaller pieces.

nakihito mentioned this in D3510: Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files).Jul 2 2019, 01:31
nakihito mentioned this in D3512: Merge #13163: Make it clear which functions that are intended to be translation unit local (validation.cpp).
Nico Guiton <nico@bitframe.org> mentioned this in rABCe8149e5398f7: Merge #13163: Make it clear which functions that are intended to be translation….Jul 2 2019, 17:18
Nico Guiton <nico@bitframe.org> mentioned this in rABCd5a3ed098b32: Merge #13163: Make it clear which functions that are intended to be translation….Jul 2 2019, 17:25
nakihito mentioned this in D3522: Merge #13163: Make it clear which functions that are intended to be translation unit local (init.cpp).Jul 2 2019, 17:29
nakihito mentioned this in D3523: Merge #13163: Make it clear which functions that are intended to be translation unit local (rpc/rawtransaction.cpp).Jul 2 2019, 18:03
nakihito mentioned this in D3524: Merge #13163: Make it clear which functions that are intended to be translation unit local (bitcoind.cpp).Jul 2 2019, 18:08
Nico Guiton <nico@bitframe.org> mentioned this in rABC29185c903215: Merge #13163: Make it clear which functions that are intended to be translation….Jul 2 2019, 19:27
Nico Guiton <nico@bitframe.org> mentioned this in rABCad96d594f415: Merge #13163: Make it clear which functions that are intended to be translation….Jul 2 2019, 20:03
Nico Guiton <nico@bitframe.org> mentioned this in rABCeb2266b3cd7d: Merge #13163: Make it clear which functions that are intended to be translation….Jul 2 2019, 20:23
nakihito mentioned this in D3529: Merge #13163: Make it clear which functions that are intended to be translation unit local (test/uint256_tests.cpp).Jul 2 2019, 21:48
nakihito mentioned this in D3526: Make printchunk() in support/lockedpool.cpp static.Jul 2 2019, 22:07
markblundeberg mentioned this in D3530: Make various functions in src/test/ static.Jul 2 2019, 22:59
nakihito abandoned this revision.Jul 2 2019, 23:49

This has been broken into smaller parts. See D3530, D3526, D3525, D3524, D3523, D3522, D3512, D3510.

Nico Guiton <nico@bitframe.org> mentioned this in rABCa6e7748423d6: Make printchunk() in support/lockedpool.cpp static.Jul 8 2019, 16:36
Nico Guiton <nico@bitframe.org> mentioned this in rABCbefd21523dc6: Make various functions in src/test/ static.Jul 8 2019, 19:04
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGINGe8149e5398f7: Merge #13163: Make it clear which functions that are intended to be translation….Sep 19 2019, 00:51
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGINGd5a3ed098b32: Merge #13163: Make it clear which functions that are intended to be translation….
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGING29185c903215: Merge #13163: Make it clear which functions that are intended to be translation….
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGINGad96d594f415: Merge #13163: Make it clear which functions that are intended to be translation….
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGINGeb2266b3cd7d: Merge #13163: Make it clear which functions that are intended to be translation….
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGINGa6e7748423d6: Make printchunk() in support/lockedpool.cpp static.Sep 19 2019, 01:04
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGINGbefd21523dc6: Make various functions in src/test/ static.

Revision Contents
Changeset List

Diff 9779

View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoind.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/support/lockedpool.cpp

Loading...
View Options

src/test/DoS_tests.cpp

Loading...
View Options

src/test/arith_uint256_tests.cpp

Loading...
View Options

src/test/bip32_tests.cpp

Loading...
View Options

src/test/coins_tests.cpp

Loading...
View Options

src/test/crypto_tests.cpp

Loading...
View Options

src/test/cuckoocache_tests.cpp

Loading...
View Options

src/test/dbwrapper_tests.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/multisig_tests.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/sigopcount_tests.cpp

Loading...
View Options

src/test/test_bitcoin_fuzzy.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...
View Options

src/test/uint256_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...