Page MenuHomePhabricator

Merge #13163: Make it clear which functions that are intended to be translation unit local
AbandonedPublic

Authored by nakihito on Jun 11 2019, 22:29.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Backport of Core PR13163
https://github.com/bitcoin/bitcoin/pull/13163/

Depends on D3285

Should be landed immediately after dependencies.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13163
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6542
Build 11131: Bitcoin ABC Buildbot (legacy)
Build 11130: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jun 11 2019, 22:29

bench/prevector.cpp: https://reviews.bitcoinabc.org/D3061

bitcoin-cli.cpp: https://reviews.bitcoinabc.org/D3058

core_read.cpp change looks like witness code: https://github.com/bitcoin/bitcoin/pull/10481/files

Could not find where/when the code for the last change in init.cpp was removed, but I found a backport that would have touched it and the original Core PR that added it:
https://reviews.bitcoinabc.org/D2260
https://github.com/bitcoin/bitcoin/pull/5677

net.cpp: https://reviews.bitcoinabc.org/D1863

net_processing.cpp:
https://reviews.bitcoinabc.org/D1879
Last change is witness code

random.cpp: https://reviews.bitcoinabc.org/D1939

rpc/blockhcain.cpp: https://reviews.bitcoinabc.org/D2952

rpc/mining.cpp: https://reviews.bitcoinabc.org/D35

rpc/misc.cpp: https://reviews.bitcoinabc.org/D44#change-NtxAgEAFHeNl

rpc/net.cpp: https://reviews.bitcoinabc.org/D44#change-NtxAgEAFHeNl

rpc/rawtransaction.cpp
https://reviews.bitcoinabc.org/D3013#change-nhUnShmRryR1
https://reviews.bitcoinabc.org/D44#change-nhUnShmRryR1

rpc/server: https://reviews.bitcoinabc.org/D1039

src/test/blockchain_tests.cpp: https://reviews.bitcoinabc.org/D3012

src/test/checkqueue_tests.cpp: https://reviews.bitcoinabc.org/D1771

src/test/coins_tests.cpp: https://reviews.bitcoinabc.org/D515

src/test/versionbits_tests.cpp: https://reviews.bitcoinabc.org/D2783

src/validation.cpp:
https://reviews.bitcoinabc.org/D1667 updateMempoolForReorg moved to txmempool.cpp

src/wallet/rpcwallet.cpp:
https://reviews.bitcoinabc.org/D44#change-4q6XVS3POqj5
https://reviews.bitcoinabc.org/D1035
https://github.com/bitcoin/bitcoin/pull/12892/files last two functions added here

Going to try and break this into smaller pieces.

This has been broken into smaller parts. See D3530, D3526, D3525, D3524, D3523, D3522, D3512, D3510.